He is a former Speaker of the Punjab Assembly.He was born in Montgomery in Pakistan and graduated from GGN Khalsa College, Ludhiana. He obtained the LLB degree from Punjab University, Chandigarh and was Speaker of the Punjab Assembly from 1997-2002. Earlier he was a member of the Lok Sabha from 1985-1989.
from 1997 to 2000 he was Chairman of the Committee on Welfare of Scheduled Castes, Scheduled Tribes and Backward Classes. He was jailed during 1975-77 emergency.